Open
Conversation
Contributor
|
Here's the code health analysis summary for commits Analysis Summary
|
Contributor
|
|
Contributor
Author
😭 |
Contributor
这一部分代码我想提出一点修改建议:
1.密码哈希我想你应该做成全局变量,这样可以提高一些效率。毕竟每一个请求都要哈希一次有点浪费资源了。
2.请求登录nv1可以只登录一次后保存重复使用，当然也要做好失效的检测。这样做对于nv1和玩家是友好的。
|
Contributor
|
还有，requests本身带有.json()方法转化成json。如果你想统一处理可以把请求单独封装成一个函数，让他做处理 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NV1 辅助用户循环签到，用于给机器人涨经验值